Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lazy<Module> concrete implementation & missing "plus" operator #1756

Merged
merged 5 commits into from
Mar 29, 2024

Conversation

cpaleop
Copy link
Contributor

@cpaleop cpaleop commented Jan 11, 2024

Resolves #1755 by creating a LazyModule class that implements Lazy<Module> and also adds the missing "plus" (+) operator.

@arnaudgiuliani arnaudgiuliani added the status:checking currently in analysis - discussion or need more detailed specs label Jan 16, 2024
@arnaudgiuliani arnaudgiuliani added this to the core-3.6.0 milestone Jan 25, 2024
# Conflicts:
#	projects/core/koin-core-coroutines/src/commonMain/kotlin/org/koin/core/module/LazyModule.kt
@arnaudgiuliani arnaudgiuliani changed the base branch from main to 3.6.0 February 15, 2024 15:18
Copy link
Member

@arnaudgiuliani arnaudgiuliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's play with more test sample if we can :)

@cpaleop
Copy link
Contributor Author

cpaleop commented Mar 21, 2024

Resolved the conflicts, let me know if there is anything else I need to care of :)

@arnaudgiuliani
Copy link
Member

Thanks, should be ok.

@arnaudgiuliani arnaudgiuliani merged commit 49ea507 into InsertKoinIO:3.6.0 Mar 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core coroutines status:checking currently in analysis - discussion or need more detailed specs type:improvement Improving a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing "plus" operator for Lazy<Module>
2 participants