Breaking looping linked scopes when first got instance. #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaudgiuliani
added
status:accepted
|
thanks, will merge it soonly 👍 |
arnaudgiuliani
approved these changes
Apr 22, 2020
|
Hello @scraplesh , can you provide a test (unit test if possible) to reproduce it? thanks |
arnaudgiuliani
requested changes
May 15, 2020
if instance not found in current scope. Fixes InsertKoinIOgh-689
Added test case as you requested, pushed to my fork. But this pull request not updated yet. Don't know how to properly update it with my new commit. |
|
Try to push to |
All good, commit appeared in pull request 👍 |
arnaudgiuliani
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689