Skip to content

Commit

Permalink
comment added for CHECK_NOFAIL
Browse files Browse the repository at this point in the history
  • Loading branch information
remibettan committed Jan 24, 2021
1 parent 1c9863d commit e56a9aa
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions unit-tests/log/test-multi-thread-logs.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,8 @@ TEST_CASE("async logger", "[log][async_log]")
CAPTURE(max_time);
CAPTURE(min_time);
CAPTURE(avg_time);
// The threshold in the CHECK_NOFAIL statement should be filled when running in "normal PC"
// The threshold in the REQUIRE statement should be filled when running CI tests (less cores are available there)
CHECK_NOFAIL(max_time.count() < checked_log_write_time);
REQUIRE(max_time.count() < required_log_write_time);

Expand Down Expand Up @@ -197,6 +199,8 @@ TEST_CASE("async logger", "[log][async_log]")
auto delta = std::abs(log_ideal_time_ms - log_time_ms);
if (delta > max_delta) max_delta = delta;
}
// The threshold in the CHECK_NOFAIL statement should be filled when running in "normal PC"
// The threshold in the REQUIRE statement should be filled when running CI tests (less cores are available there)
CHECK_NOFAIL(max_delta < checked_lag_time);
REQUIRE(max_delta < required_lag_time);
}
Expand Down

0 comments on commit e56a9aa

Please sign in to comment.