Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation error with -Wall in clang (patch attached) #1292

Closed
richardroberts opened this issue Mar 6, 2018 · 4 comments
Closed

Compilation error with -Wall in clang (patch attached) #1292

richardroberts opened this issue Mar 6, 2018 · 4 comments
Assignees
Labels

Comments

@richardroberts
Copy link


Required Info
Camera Model D400
Firmware Version N/A
Operating System & Version Linux
Kernel Version (Linux Only) N/A
Platform PC
SDK Version 2.9.0

Issue Description

Minor compilation error with -Wall (which we're required to use here), patch attached here:
compilation_error_fix_richardroberts.patch.txt

By the way, I'd be glad to submit these minor fixes as pull requests if that makes things easier! Is there a permission change that I need to be able to push to a new branch? Currently I get this error:
ERROR: Permission to IntelRealSense/librealsense.git denied to richardroberts. fatal: Could not read from remote repository.

@ev-mp
Copy link
Collaborator

ev-mp commented Mar 6, 2018

Hi @richardroberts , thanks for the patch.
You are welcomed to create Pull Request and submit this patch to the development branch for review and merge.

@zivsha
Copy link
Contributor

zivsha commented Mar 6, 2018

@richardroberts yo can fork (upper right corner of GitHub) the repo and push to a branch there, then submit a PR to development on librealsense

@RealSense-Customer-Engineering
Copy link
Collaborator

[Realsense Customer Engineering Team Comment]
Hi, @RichardRobert,
Didn't see your PR, have you created PR?

dorodnic added a commit to dorodnic/librealsense that referenced this issue Apr 3, 2018
…#1292 by @richardroberts

(cherry picked from commit 513f21500a2c01d442e12d2561aa2c08148d063f)
@richardroberts
Copy link
Author

Thanks for the help Sergey, in the future I'll try again to create a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants