-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aligned Point Cloud possibly still utilizing wrong intrinsics #3752
Comments
Confirming that I can generate a valid point cloud from aligned data so it appears the point cloud generation code is not utilizing the right intrinsic information. |
@joki123 hello and thank you for the report and the additional info. |
- The alignment must update the extrinsic of the new profile. - the alignment shall filter inputs and avoid non-video frames passed on, otherwise the blocks fails with exception This addresses IntelRealSense#3752 Tracked on: DSO-12515 Change-Id: I189a77710733245cd13644807420830b0d9bc432 Signed-off-by: Evgeni Raikhel <evgeni.raikhel@intel.com>
@joki123 , the fix was merged into the recently released v2.21.0. Do you still observe discrepancies with that version ? Please update |
Thanks for the fix! It's greatly appreciated. I'll check it out. I've been
creating point clouds via a third-party library instead.
…On Wed, May 1, 2019 at 11:29 AM ev-mp ***@***.***> wrote:
@joki123 <https://github.com/joki123> , the fix was merged into the
recently released v2.21.0. Do you still observe discrepancies with that
version ? Please update
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3752 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AL2G7PAGV3F4MSLYUDAYEZTPTHOQPANCNFSM4HFWXOUQ>
.
|
Hi @joki123, |
Actually the fix came a bit too late we ended up creating point clouds from
a third-party library. I'm sure this fixed will greatly help other people
however!
…On Tue, May 14, 2019, 4:18 PM RealSense Customer Support < ***@***.***> wrote:
------------------------------
Hi @joki123 <https://github.com/joki123>,
Do you have a chance to check out v2.21.0?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3752?email_source=notifications&email_token=AL2G7PEBQJQ747OZMQ7CBT3PVNCC3A5CNFSM4HFWXOU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVNB5XI#issuecomment-492445405>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AL2G7PG3DIEHWLVZL7AMUQDPVNCC3ANCNFSM4HFWXOUQ>
.
|
Hi joki123, Thanks for the updates. Glad to hear that you have already addressed the issue. Thanks! |
I'm opening a new issue because issue #2002 was closed out. I'm running the following code:
rs2::pipeline_profile profile = pipe.start();
float depth_scale = get_depth_scale(profile.get_device());
rs2_stream align_to = find_stream_to_align(profile.get_streams());
rs2::align align(align_to);
for (auto i = 0; i < 30; ++i) {
pipe.wait_for_frames();
}
auto processed = align.process(pipe.wait_for_frames());
rs2::video_frame rgb_vf = processed.first(align_to);
rs2::depth_frame raw_df = processed.get_depth_frame();
rs2::pointcloud pc;
rs2::points points;
pc.map_to(rgb_vf);
points = pc.calculate(raw_df);
points.export_to_ply("test.ply", rgb_vf);
I received some assistance from Sergey Dorodnicov and we established that not aligned (raw, or original sized) pointclouds can be generated just fine and that the resulting pointclouds from running the code above definitely appear to be misaligned.
Are aligned point clouds using wrong intrinsics? If not, is it possible the alignment code might not be working properly? Note: alignment code above is taken from SDK examples.
The text was updated successfully, but these errors were encountered: