Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LRS Linux kernel support for Y16i #10745

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

dmipx
Copy link
Contributor

@dmipx dmipx commented Aug 3, 2022

Ubuntu jammy 5.15
Ubuntu focal 5.4, 5.8, 5.11, 5.13, 5.15
Ubuntu bionic 5.4
Addressing

Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com

@dmipx
Copy link
Contributor Author

dmipx commented Aug 3, 2022

@Nir-Az @ev-mp
Please review

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there changes more than supporting Y16I?
I see removal of confidence? more new formats?
There are some failed tests that needs to be investigates.
I rerun and it happened again.
Last night development branch CI passed.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Aug 4, 2022

Why are there changes more than supporting Y16I? I see removal of confidence? more new formats? There are some failed tests that needs to be investigates. I rerun and it happened again. Last night development branch CI passed.

As discussed with @dmipx , this change should be origined from development with no fail tests.

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @ev-mp can you also take a look please?

@Nir-Az Nir-Az requested a review from ev-mp August 4, 2022 11:11
@ev-mp
Copy link
Collaborator

ev-mp commented Aug 9, 2022

@dmipx , what about patching Ubuntu16?

@dmipx
Copy link
Contributor Author

dmipx commented Aug 10, 2022

@dmipx , what about patching Ubuntu16?

AFAIK ubuntu 16 latest kernel is 4.15, you defined
3. Linux kernel patches for Y16I (Version >= 5.4)

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but shouldn't it also be retrofitted to additional distros/LTS?

@@ -132,14 +141,15 @@ index 58868d7129eb..c29033b8439c 100644
+ case V4L2_PIX_FMT_INZC: descr = "Planar Depth/Confidence (INZC)"; break;
+ case V4L2_PIX_FMT_PAIR: descr = "Relative IR (PAIR)"; break;
+ case V4L2_PIX_FMT_Z16H: descr = "Z16 Huffman Compression"; break;
+ case V4L2_PIX_FMT_Y16I: descr = "Interleaved 16-bit Greyscale"; break;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make more sense to inject the line immedeately after Y12I ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@dmipx dmipx force-pushed the LRS-470-kernel-Y16i branch 4 times, most recently from 0388e4d to 9bcc0a0 Compare August 21, 2022 13:09
@dmipx
Copy link
Contributor Author

dmipx commented Aug 21, 2022

Looks fine, but shouldn't it also be retrofitted to additional distros/LTS?

done for xenial hwe

  Ubuntu jammy 5.15
  Ubuntu focal 5.4, 5.8, 5.11, 5.13, 5.15
  Ubuntu bionic 4.15, 5.0, 5.4
  Ubuntu xenial master-4.4, hwe-4.15, hwe-zesty-4.10
  Addressing
   - [HKR HSD] - LRS Linux kernel support for Y16i [LRS-470]

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
@dmipx
Copy link
Contributor Author

dmipx commented Sep 1, 2022

now supports jammy, kernels 5.13 and 1.15

@Nir-Az Nir-Az merged commit 6fc9bc3 into IntelRealSense:development Sep 1, 2022
@dmipx dmipx deleted the LRS-470-kernel-Y16i branch February 26, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants