-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LRS Linux kernel support for Y16i #10745
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there changes more than supporting Y16I?
I see removal of confidence? more new formats?
There are some failed tests that needs to be investigates.
I rerun and it happened again.
Last night development branch CI passed.
As discussed with @dmipx , this change should be origined from development with no fail tests. |
f336d82
to
b524c57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @ev-mp can you also take a look please?
@dmipx , what about patching Ubuntu16? |
AFAIK ubuntu 16 latest kernel is 4.15, you defined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but shouldn't it also be retrofitted to additional distros/LTS?
@@ -132,14 +141,15 @@ index 58868d7129eb..c29033b8439c 100644 | |||
+ case V4L2_PIX_FMT_INZC: descr = "Planar Depth/Confidence (INZC)"; break; | |||
+ case V4L2_PIX_FMT_PAIR: descr = "Relative IR (PAIR)"; break; | |||
+ case V4L2_PIX_FMT_Z16H: descr = "Z16 Huffman Compression"; break; | |||
+ case V4L2_PIX_FMT_Y16I: descr = "Interleaved 16-bit Greyscale"; break; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make more sense to inject the line immedeately after Y12I ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
0388e4d
to
9bcc0a0
Compare
done for xenial hwe |
5947329
to
5290b1f
Compare
Ubuntu jammy 5.15 Ubuntu focal 5.4, 5.8, 5.11, 5.13, 5.15 Ubuntu bionic 4.15, 5.0, 5.4 Ubuntu xenial master-4.4, hwe-4.15, hwe-zesty-4.10 Addressing - [HKR HSD] - LRS Linux kernel support for Y16i [LRS-470] Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
5290b1f
to
cd0323b
Compare
now supports jammy, kernels 5.13 and 1.15 |
Ubuntu jammy 5.15
Ubuntu focal 5.4, 5.8, 5.11, 5.13, 5.15
Ubuntu bionic 5.4
Addressing
Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com