Fix DSO-18454 laser turned off after calibration #10948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Sep 29, 2022
Nir-Az
reviewed
Sep 29, 2022
Nir-Az
reviewed
Sep 29, 2022
Nir-Az
reviewed
Sep 29, 2022
ev-mp
requested changes
Oct 2, 2022
common/on-chip-calib.cpp
Outdated
Comment on lines
1132
to
1142
| if (_sub->s->supports( RS2_OPTION_EMITTER_ENABLED )) | ||
| { | ||
| laser_status_prev = _sub->s->get_option( RS2_OPTION_EMITTER_ENABLED ); | ||
| _sub->s->set_option( RS2_OPTION_EMITTER_ENABLED, 0.0f ); | ||
| } | ||
| if (_sub->s->supports( RS2_OPTION_THERMAL_COMPENSATION )) | ||
| { | ||
| thermal_loop_prev = _sub->s->get_option( RS2_OPTION_THERMAL_COMPENSATION ); | ||
| _sub->s->set_option( RS2_OPTION_THERMAL_COMPENSATION, 0.f ); | ||
| } | ||
|
|
There was a problem hiding this comment.
By moving the code here those set/get options will be executed every iteration cycle (this is part of the main loop)- this may affect performance.
Imho, the best option is to create kind of LUT that for each state will define the state of laser/AE/Thermal loop controls, and that we'll use some 'enter_state(calib_1) /exist_state(calib_1)'
There was a problem hiding this comment.
This is called only once
Later on calibrate calls run_on_chip_calibration and inside that function implementation there is a loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on DSO-18454