-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ROS2 build step for LibRealSense #11100
Add ROS2 build step for LibRealSense #11100
Conversation
changed to build with ament_cmake
Please (carefully) squash this 35 commits into 1, |
|
||
# Rolling Ridley | ||
- docker_image: ubuntu:jammy | ||
ros_distribution: rolling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see rolling in the matrix (line 16), why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that 4 jobs were tested by GHA but in the matrix, we have only 3 ros-distribution, so I see that "rolling" was tested too.
In addition, according to the sample no need specify "rolling" in the matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they may have missed it... try.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rolling added.
Passed GHA but, I will check if we have a difference in results/test later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, now please revert the error :)
Do we know if the GHA test will fail if the build fails? |
3cc7471
to
cfc206f
Compare
2 errors was injected in two files
3182761
to
bcde8cb
Compare
The syntax error was injected to rs.hpp (";" character was deleted). Console output:
|
Tracked on LRS-546