Streaming tests using flexible-msg #11102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OhadMeir
reviewed
Nov 14, 2022
| { | ||
| return json::from_cbor( _data.begin(), _data.end() ); | ||
| } | ||
| DDS_THROW( runtime_error, "non-json flexible data is still unsupported" ); |
There was a problem hiding this comment.
CBOR is supported now, maybe "Custom data is not supported yet"
There was a problem hiding this comment.
Well, it's a function called json_data() and if we add other formats, they won't be supported either...
OhadMeir
reviewed
Nov 14, 2022
| py::enum_< durability >( m, "durability" ) | ||
| .value( "volatile", eprosima::fastdds::dds::DurabilityQosPolicyKind::VOLATILE_DURABILITY_QOS ) | ||
| .value( "transient_local", eprosima::fastdds::dds::DurabilityQosPolicyKind::TRANSIENT_LOCAL_DURABILITY_QOS ) | ||
| .value( "transient", eprosima::fastdds::dds::DurabilityQosPolicyKind::TRANSIENT_DURABILITY_QOS ); |
There was a problem hiding this comment.
We are not using TRANSIENT, if adding values we don't use there is also PERSISTENT durability
There was a problem hiding this comment.
It's not about whether it's being used or not; it's about whether it's available. PERSISTENT is not supported, so I did not add.
OhadMeir
reviewed
Nov 14, 2022
| else: | ||
| raise RuntimeError( "invalid 'name' argument: " + type(name) ) | ||
| self.writer = dds.topic_writer( self.handle ) | ||
| self.writer.run( qos or dds.topic_writer.qos( dds.reliability.reliable, dds.durability.transient_local ) ) |
There was a problem hiding this comment.
It's a left-over from my experiments trying to make it work with the single line. I don't think it's needed any more, but for now harmless. I'll remove later.
OhadMeir
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.