Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize timestamp domain test #11167

Conversation

Tamir91
Copy link
Contributor

@Tamir91 Tamir91 commented Dec 5, 2022

Tracked on [LRS-567]
two queues were created for each type of sensor.
A queue was increased to 1 frame.

two queues were created for each type of sensor.
A queue was increased to 10 frames.
@Tamir91 Tamir91 marked this pull request as ready for review December 6, 2022 06:56
@Tamir91 Tamir91 requested a review from Nir-Az December 6, 2022 09:13
@Nir-Az
Copy link
Collaborator

Nir-Az commented Dec 6, 2022

two queues were created for each type of sensor. A queue was increased to 10 frames.

I see the capacity is 1, please update

@Tamir91
Copy link
Contributor Author

Tamir91 commented Dec 6, 2022

It was 1 in the previous code version, but I checked with size=10 yesterday and found it failing the test.
I will run the test with queue size=5 and update you.

The capacity of a queue is 5.
In case of a failure, data fame printed.
@Nir-Az
Copy link
Collaborator

Nir-Az commented Dec 6, 2022

It was 1 in the previous code version, but I checked with size=10 yesterday and found it failing the test. I will run the test with queue size=5 and update you.

No need for more then 1

Unnecessary "IF" statement was removed.
The frame queue size changed back to 1.
@Nir-Az Nir-Az self-requested a review December 6, 2022 18:33
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az changed the title two queues created Stabilize timestamp domain test Dec 7, 2022
@Nir-Az Nir-Az merged commit 926e65b into IntelRealSense:development Dec 7, 2022
@Tamir91 Tamir91 deleted the bug/test-timestamp-domain-color-sensor-issue branch December 22, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants