Remove boost from realsense-file #11305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Jan 10, 2023
third-party/realsense-file/rosbag/roscpp_serialization/include/ros/serialization.h
Show resolved
Hide resolved
Nir-Az
reviewed
Jan 10, 2023
third-party/realsense-file/rosbag/roscpp_serialization/include/ros/serialization.h
Show resolved
Hide resolved
Nir-Az
reviewed
Jan 10, 2023
|
I still see boost reference in the cmakelist.txt and the other cmake file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost was the reason we got a lot of messages during compilation:
Unknown compiler version - please run the configure tests and report the resultsIt wasn’t c++20-compatible unless we upgraded it, but that was taking up too much space and complexity.
Instead, chose to remove it altogether.
Tracked on [LRS-619]
Build at:
https://rsjenkins.iil.intel.com/view/LRS/job/LRS_release_flow_pipeline/4736/
Warning counts are now 1/2/3 :)