Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables initialization added #11343

Merged
merged 2 commits into from
Jan 24, 2023
Merged

Variables initialization added #11343

merged 2 commits into from
Jan 24, 2023

Conversation

Tamir91
Copy link
Contributor

@Tamir91 Tamir91 commented Jan 23, 2023

[Tracked on LRS-645 & LRS-646]

A Klocwork critical errors fixing.

@Tamir91 Tamir91 self-assigned this Jan 23, 2023
@Tamir91 Tamir91 requested a review from OhadMeir January 23, 2023 13:21
@Nir-Az
Copy link
Collaborator

Nir-Az commented Jan 23, 2023

@OhadMeir / @Tamir91 checkout the cppcheck that failed, that's great!
Need to add a new log on this PR.

@OhadMeir
Copy link
Contributor

@OhadMeir / @Tamir91 checkout the cppcheck that failed, that's great! Need to add a new log on this PR.

This is part of the updated static_analisys step (Eran's PR). When reducing number of issues need to also update the expected results file

OhadMeir
OhadMeir approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit bfeb04f into IntelRealSense:development Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OhadMeir OhadMeir OhadMeir approved these changes

Assignees

@Tamir91 Tamir91

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tamir91 @Nir-Az @OhadMeir