Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry on "set_xu" when device is busy #11378

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Jan 30, 2023

Tracked on [LRS-662]

@@ -1554,7 +1554,7 @@ namespace librealsense
static_cast<uint16_t>(size), const_cast<uint8_t *>(data)};
if(xioctl(_fd, UVCIOC_CTRL_QUERY, &q) < 0)
{
if (errno == EIO || errno == EAGAIN) // TODO: Log?
if (errno == EIO || errno == EAGAIN || errno == EBUSY) // TODO: Log?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.
Maybe we can remove the meaningless comment there?

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment - besides that LGTM

Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 4b8f7f6 into IntelRealSense:development Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants