Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D457 MIPI enable multiple cameras for single DES. #11385

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

dmipx
Copy link
Contributor

@dmipx dmipx commented Feb 1, 2023

Following DSO-18585 PR #11070
For use with jp5-2d457-1-des

Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com

Following DSO-18585 PR IntelRealSense#11070
For use with jp5-2d457-1-des

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
@Nir-Az
Copy link
Collaborator

Nir-Az commented Feb 1, 2023

@hsuys can you please verify this does not break your multi MIPI cams test?

@@ -786,7 +787,7 @@ namespace librealsense
// are not available via mipi
// TODO - find a way to assign unique id for mipi
// maybe using bus_info and card params (see above in this method)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the above comment.
and the line comment
Until we will add dynamic binding we use bus info which is unique for a singe deserializer and cam_id which is unique to each camera connected to it, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
…me.h

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + CI internal + val flows passed

@Nir-Az Nir-Az merged commit 23587b5 into IntelRealSense:development Feb 6, 2023
@dmipx dmipx deleted the backend-jp-dual-cam branch February 26, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants