-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update third-party:tinyfiledialogs version to 3.9.0: cleanup format-overflow warning #11396
update third-party:tinyfiledialogs version to 3.9.0: cleanup format-overflow warning #11396
Conversation
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Lets first see if we can update the third party to fix it.
|
https://sourceforge.net/projects/tinyfiledialogs/ |
@@ -4034,7 +4034,7 @@ static int tkinter2Present(void) | |||
{ | |||
static int lTkinter2Present = -1 ; | |||
char lPythonCommand[256]; | |||
char lPythonParams[256] = | |||
char lPythonParams[224] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why 224 is better than 256?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lPythonParams copied to lPythonCommand.
lPythonParams is constant strings that never reach more than 218 characters (line 4080)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one minor comment
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com