Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default dds participant name in context to the executable name #11536

Merged
merged 7 commits into from
Mar 8, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Mar 7, 2023

Before, all instances of librealsense programs were identified with librealsense and you couldn't really distinguish unless the coder specified the participant name in the json.

Now it gets the executable name by default and uses it.

Tested under Windows and Linux.

@maloel maloel requested a review from OhadMeir March 7, 2023 12:17
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 2a6e33d into IntelRealSense:dds Mar 8, 2023
@maloel maloel deleted the ddsros branch March 8, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants