Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create temporary file in build directory instead of source #11766

Merged
merged 1 commit into from
May 4, 2023

Conversation

Allius27
Copy link
Contributor

@Allius27 Allius27 commented May 4, 2023

Hello

I think that would be better to create connectivity_check file in build directory, instead of source

For example, we have a build process in docker under custom user, and that user don't have permissions to modify sources

BR

@Nir-Az
Copy link
Collaborator

Nir-Az commented May 4, 2023

Hi @Allius27 ,
Sounds like a good idea, let see how the CI will like and and later we can merge it.
Thanks!

@Nir-Az Nir-Az changed the base branch from master to development May 4, 2023 14:32
@Nir-Az Nir-Az closed this May 4, 2023
@Nir-Az Nir-Az reopened this May 4, 2023
@Nir-Az
Copy link
Collaborator

Nir-Az commented May 4, 2023

Changed target branch to development (as requested in our https://github.com/IntelRealSense/librealsense/blob/master/CONTRIBUTING.md file) and retriggered Ci run

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 469d0ca into IntelRealSense:development May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants