Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adlp metadata #11822

Merged
merged 4 commits into from
May 25, 2023
Merged

Adlp metadata #11822

merged 4 commits into from
May 25, 2023

Conversation

dmipx
Copy link
Contributor

@dmipx dmipx commented May 21, 2023

Set metadata configuration.
Need to add md structure patch for LibCI.
Fix udev rules for mipi dfu.

@dmipx dmipx requested review from remibettan and Nir-Az May 21, 2023 07:38
Copy link
Contributor

@remibettan remibettan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please run this code over jetson before merging it.

if ((_dev.cap.capabilities & V4L2_CAP_VIDEO_CAPTURE_MPLANE) && !is_platform_jetson())
{
/* Sakari patch for videodev2.h. This structure will be within kernel > 6.4 */
struct v4l2_meta_format {
Copy link
Contributor Author

@dmipx dmipx May 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. @Nir-Az
this is union with 200 bytes so we don't care about some integers appended.

struct v4l2_format {
	__u32	 type;
	union {
		struct v4l2_pix_format		pix;     /* V4L2_BUF_TYPE_VIDEO_CAPTURE */
		struct v4l2_pix_format_mplane	pix_mp;  /* V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE */
		struct v4l2_window		win;     /* V4L2_BUF_TYPE_VIDEO_OVERLAY */
		struct v4l2_vbi_format		vbi;     /* V4L2_BUF_TYPE_VBI_CAPTURE */
		struct v4l2_sliced_vbi_format	sliced;  /* V4L2_BUF_TYPE_SLICED_VBI_CAPTURE */
		struct v4l2_sdr_format		sdr;     /* V4L2_BUF_TYPE_SDR_CAPTURE */
		struct v4l2_meta_format		meta;    /* V4L2_BUF_TYPE_META_CAPTURE */
		__u8	raw_data[200];                   /* user-defined */
	} fmt;
};

@dmipx dmipx force-pushed the adlp-metadata branch 2 times, most recently from ad26ef4 to cc0f189 Compare May 24, 2023 11:53
dmipx added 4 commits May 24, 2023 14:57
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Metadata structure will be changed in future kernel releases,
expected from version > 6.4.
This patch helps avoid system header file change with Sakari metadata patch.

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
@dmipx
Copy link
Contributor Author

dmipx commented May 24, 2023

LGTM Please run this code over jetson before merging it.

done. works fine.

@dmipx
Copy link
Contributor Author

dmipx commented May 24, 2023

@Nir-Az can we merge?

@Nir-Az Nir-Az merged commit c2b47dd into IntelRealSense:adl-p May 25, 2023
@dmipx dmipx deleted the adlp-metadata branch January 7, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants