Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add BUILD_LEGACY_PYBACKEND default OFF #12124

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Aug 22, 2023

Remove pybackend from regular builds (including libCI).
Added a flag to re-enable manually in CMake.
Tested release flow.

@maloel maloel requested a review from OhadMeir August 22, 2023 06:21
Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel merged commit 36a0745 into IntelRealSense:development Aug 23, 2023
14 of 16 checks passed
@maloel maloel deleted the pybackend branch August 23, 2023 12:34
@Nir-Az
Copy link
Collaborator

Nir-Az commented Aug 28, 2023

@yorambenhaim / @ymodlin FY1,
Does the FW gating use pybackend?

@maloel
Copy link
Collaborator Author

maloel commented Aug 29, 2023

@yorambenhaim / @ymodlin FY1, Does the FW gating use pybackend?

They do. We compile it for them on demand, but this never really happens: they have a copy that doesn't change.
I have a task to remove pybackend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants