Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced travis with Github Actions on readme files #12225

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

AviaAv
Copy link
Contributor

@AviaAv AviaAv commented Sep 27, 2023

Tracked on [LRS-876]

@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 1, 2023

Nice!

Let's speak about this PR.

  1. Adding Tracked on [...] comment
  2. Squash commits
  3. Remove AppVeyor links
  4. Use absolute links rather than relative once
  5. Adding a reviewer

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix conflicts

@AviaAv
Copy link
Contributor Author

AviaAv commented Oct 2, 2023

Probably was because of the issues with github earlier, thinking it should be ok now. @Nir-Az

@@ -22,12 +22,12 @@ This mode of operation lets you test your code on a variety of simulated devices

## Test Data

If you would like to run and debug unit-tests locally on your machine but you don't have a RealSense device, we publish a set of *unit-test* recordings. These files capture expected execution of the test-suite over several types of hardware (D415, D435, etc..)
Please see [.travis.yml](https://github.com/IntelRealSense/librealsense/blob/master/.travis.yml#L80) and [appveyor.yml](https://github.com/IntelRealSense/librealsense/blob/master/appveyor.yml#L35) for the exact URLs.
If you would like to run and debug unit-tests locally on your machine but you don't have a RealSense device, we publish a set of *unit-test* recordings. These files capture expected execution of the test-suite over several types of hardware (D415, D435, SR300, etc..)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is still wrong.
Notice the SR300 "you" added.

@Nir-Az Nir-Az merged commit 26911d3 into IntelRealSense:development Oct 2, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants