Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pybind arg names #12309

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix pybind arg names #12309

merged 1 commit into from
Oct 25, 2023

Conversation

oceanusxiv
Copy link

There was a previous fix #11273 to fix the internal ordering, but that was never propagated to the actual pybind function definitiion.

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@Nir-Az Nir-Az merged commit b831660 into IntelRealSense:master Oct 25, 2023
15 of 16 checks passed
Nir-Az added a commit to Nir-Az/librealsense that referenced this pull request Oct 25, 2023
@Nir-Az
Copy link
Collaborator

Nir-Az commented Oct 25, 2023

@oceanusxiv please note next time to open PR's based on development branch as this was accidently merged to master 🤦‍♂️
See CONTRIBUTING

@oceanusxiv
Copy link
Author

@Nir-Az Oh apologies, I will keep that in mind for the future.

@oceanusxiv oceanusxiv deleted the fix_pyrsutil branch October 29, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants