Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eth misc #12346

Merged
merged 5 commits into from
Nov 2, 2023
Merged

Eth misc #12346

merged 5 commits into from
Nov 2, 2023

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Nov 2, 2023

  • wait for a reply for dds-device open-streams
    • Without this, open-streams is received after the stream is already open
  • add eth PID to windows metadata script
  • add D500 to metadata helper (missing from dev branch)
  • metadata_helper::is_enabled() now returns true if not a USB device

Tracked on [LRS-871]

@maloel maloel requested a review from OhadMeir November 2, 2023 09:34
@@ -25,7 +25,7 @@ namespace rs2

static bool can_support_metadata(const std::string& product)
{
return product == "D400";
return product == "D400" || product == "D500";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have supported products that don't support metadata? Platform camera?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess that's the only one that's left...

Copy link
Contributor

@OhadMeir OhadMeir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maloel maloel changed the title D555e misc Eth misc Nov 2, 2023
@maloel maloel merged commit 386c6dc into IntelRealSense:development Nov 2, 2023
17 checks passed
@maloel maloel deleted the d555e branch November 2, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants