FW update aligned for D400/D500 #12395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
force-pushed
the
fw-update-updates
branch
from
2897c78
to
7c94a18
Compare
maloel
reviewed
Nov 12, 2023
maloel
reviewed
Nov 12, 2023
Nir-Az
commented
Nov 13, 2023
maloel
reviewed
Nov 13, 2023
maloel
reviewed
Nov 13, 2023
src/ds/ds-device-common.cpp
Outdated
| @@ -256,6 +257,13 @@ namespace librealsense | |||
|
|
|||
| void ds_device_common::update_flash(const std::vector<uint8_t>& image, rs2_update_progress_callback_sptr callback, int update_mode) | |||
| { | |||
| // check if the given FW size matches the expected FW size | |||
maloel
reviewed
Nov 15, 2023
src/ds/ds-device-common.cpp
Outdated
| @@ -256,6 +257,13 @@ namespace librealsense | |||
|
|
|||
| void ds_device_common::update_flash(const std::vector<uint8_t>& image, rs2_update_progress_callback_sptr callback, int update_mode) | |||
| { | |||
| // check if the given FW size matches the expected FW size | |||
| if( image.size() != unsigned_fw_size ) | |||
| throw librealsense::invalid_value_exception( rsutils::string::from() | |||
There was a problem hiding this comment.
Oh, now I see the indent issue, I fixed the comment indent before.
Fixed
maloel
approved these changes
Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on [RSDEV-733]