Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LRS-GL] Support for Align-SSE #12637

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

Arun-Prasad-V
Copy link
Contributor

Tracked on LRS-1007

With LRS-GL library, in case if user chooses CPU acceleration ('SSE3' is enabled during build), create librealsense::align_sse class object instead of librealsense::align.

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI issues

@@ -11,10 +11,30 @@
#include "align.h"
#include "stream.h"

#ifdef RS2_USE_CUDA
Copy link
Collaborator

@Nir-Az Nir-Az Feb 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible a platform will have both CUDA & SSE3 enabled?
Please check because if yes, we will have to choose as this may not compile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure @Nir-Az. Will check. But it is the same case for pointcloud implementation as well.

std::shared_ptr<pointcloud> pointcloud::create()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nir-Az, the user cannot choose to run with or without "SSE3". If CPU processing is preferred, LRS should automatically detect and use "SSE3" wherever possible.

If "BUILD_WITH_CUDA" flag is enabled, CUDA implementations will be preferred. User cannot dynamically choose between CUDA or SSE3.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I know, just wanted to make sure that if the user build with Cuda, and gis CPU support SSSE,
He will include both headers.
We need to make sure the headers does not conflict.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers are not conflicting. Anyway, updated them to avoid such confusions.

src/proc/align.cpp Outdated Show resolved Hide resolved
@Nir-Az Nir-Az merged commit b6f4aed into IntelRealSense:development Feb 14, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants