Auto removed from d500 popup, remained in d400 #12722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Mar 4, 2024
| @@ -138,6 +138,12 @@ namespace librealsense | |||
|
|
|||
| _ds_color_common->register_color_options(); | |||
|
|
|||
| color_ep.register_option(RS2_OPTION_POWER_LINE_FREQUENCY, | |||
There was a problem hiding this comment.
As I explained in the ticket.
D555e OHM is same as D400.
Meaning use a global shutter and should have AUTO value.
Only D585S should not
So looks like we will need 2 PR's
1 for dev to enable only for D555e + D400 and 1 for other repo
There was a problem hiding this comment.
OK - missed that line in the requirements - I am on it
There was a problem hiding this comment.
Done - no need for another PR I beleive
Nir-Az
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-1777