Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDS ROI support; enums in adapter #12819

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Conversation

maloel
Copy link
Collaborator

@maloel maloel commented Apr 2, 2024

  • dds sensor now extends to roi_sensor if an option exists that's named "Region of Interest"
    • this sensor directly translates set()/get() to this option
  • add dds_rect_option, communicated as an array [x1,y1,x2,y2]
  • add RS2_OPTION_REGION_OF_INTEREST, which is skipped by the Viewer
    • add a as_rect to union inside rs2_option_value
  • add ROI support to dds-adapter

Tracked on [RSDEV-1904]

Also:

  • move legacy set-option type conversion to rs-dds-option, as some options (e.g., error-polling) are set as floats from within librealsense
  • guard against exceptions in options-changed callbacks
  • add enum support to dds-adapter (enum values weren't transmitted before, so they weren't enums in the client)

@maloel maloel requested a review from OhadMeir April 2, 2024 14:30
… against exceptions in options-changed callback
@maloel maloel requested a review from OhadMeir April 10, 2024 05:41
@maloel maloel merged commit c17054a into IntelRealSense:development Apr 11, 2024
17 checks passed
@maloel maloel deleted the origin-roi branch April 11, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants