d500 auto calib added for future capabilities #12856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remibettan
force-pushed
the
auto-calib-for-d500
branch
from
8c84c2d
to
bcaa22c
Compare
Nir-Az
reviewed
Apr 16, 2024
common/d500-on-chip-calib.cpp
Outdated
| ImGui::SetCursorScreenPos({ float(x + 5), float(y + height - 28) }); | ||
| if (ImGui::Button(calibrate_button_name.c_str(), { float(bar_width), 20.f })) | ||
| { | ||
| //get_manager().restore_workspace([this](std::function<void()> a) { a(); }); |
Nir-Az
reviewed
Apr 16, 2024
common/d500-on-chip-calib.cpp
Outdated
| { | ||
| //get_manager().restore_workspace([this](std::function<void()> a) { a(); }); | ||
| get_manager().reset(); | ||
| //get_manager().retry_times = 0; |
Nir-Az
reviewed
Apr 17, 2024
src/ds/d500/d500-auto-calibration.h
Outdated
| #pragma pack(push, 1) | ||
| #pragma pack(1) | ||
|
|
||
| #pragma pack(pop) |
There was a problem hiding this comment.
Is this old code?
No data between the push pop..
There was a problem hiding this comment.
seems so - corrected
Nir-Az
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preparing for RSDEV-1470