rs2_get_video_stream_intrinsics no longer reports errors if not intrinsics available #13004
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v2.55, we report errors (
LOG_ERROR
) if API calls fail.rs-enumerate-devices -c
goes through all profiles and tries to get their intrinsics usingrs2_get_video_stream_intrinsics
.Some profiles have none, and so a
not_implemented_exception
is triggered, and thus causes error log messages that now come out.Since this function has no return value, an error is the only valid way of reporting that no intrinsics exist. Adding a return value and not throwing is a change in behavior, which I didn't want to make. We can also add a new API, remove the errors completely, or change them to debug...
Instead, I marked a
not_implemented_exception
as an "expected exception" in the code so it behaves the same but without an error.See below: I also improved the errors given:
rs2_stream_profile
arguments will actually show the profileoutput_arg( ... )
syntax, so an error would show them as(out)
Reported by CDE.
Tracked on [LRS-1130]