Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refresh the _depth_units when its changed. #2655

Merged
merged 1 commit into from
Nov 7, 2018
Merged

Refresh the _depth_units when its changed. #2655

merged 1 commit into from
Nov 7, 2018

Conversation

aangerma
Copy link
Contributor

@aangerma aangerma commented Nov 1, 2018

No description provided.

@zivsha
Copy link
Contributor

zivsha commented Nov 1, 2018

Hi!
Why not use the signal class instead of observable_option?

@dorodnic dorodnic mentioned this pull request Nov 6, 2018
Closed
@aangerma
Copy link
Contributor Author

aangerma commented Nov 7, 2018

@zivsha
Hi Ziv,
I considered to use it but I think its more readable, you can understand the code from reading it as its part of the interface of the option.

@dorodnic
Copy link
Contributor

dorodnic commented Nov 7, 2018

Looks good enough to me

@dorodnic dorodnic merged commit fb3be5e into IntelRealSense:development Nov 7, 2018
@aangerma aangerma deleted the depth_units branch November 7, 2019 09:09
gwen2018 pushed a commit to gwen2018/librealsense that referenced this pull request Dec 14, 2023
@Nir-Az
PR IntelRealSense#2655 from stwirth: Expose USB port in DeviceInfo se…
78eb9ae 
…rvice (ros2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorodnic dorodnic dorodnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aangerma @zivsha @dorodnic