Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify udev-rules application #3643

Merged
merged 1 commit into from
Apr 3, 2019

Conversation

dorodnic
Copy link
Contributor

@dorodnic dorodnic commented Apr 1, 2019

Use script instead of hard-coded commands

(cherry picked from commit 64b7bb3)
@dorodnic dorodnic changed the base branch from master to development April 1, 2019 13:53
@dorodnic dorodnic requested a review from ev-mp April 1, 2019 13:53
@dorodnic dorodnic added this to the v2.20.0 milestone Apr 1, 2019

exec 3>&2
exec 2> /dev/null
con_dev=$(ls /dev/video* | wc -l)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will find UVC but not T265. I can't thing of a generic way to have T265 boot/loaded devices other than explicit PID/VID

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also probably limit it to 8086 VID

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ev-mp ev-mp merged commit e053cc6 into IntelRealSense:development Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants