First pass at adding support for Python3.7 #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add finally to example code for pyrealsense
|
Thanks @ClimbsRocks |
|
I would manually double check that we don't need to update our version of Pybind11. While it shouldn't be a problem, we use a version that's quite old at this point. If any changes were made upstream to support python 3.7, they might be missing from our repo and cause trouble |
ev-mp
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #4008, starts to add support for Python3.7.
This PR modifies the setup.py for
pyrealsenseandpybind11to note that they work for Python3.7 as well. This will allow PyPi to pattern-match and allow downloads for Python3.7 systems. According to the linked issue, the code should be already compatible (which would make sense, Python3.7 didn't introduce much (if anything) in the way of breaking changes).Without being familiar with the rest of the CI setup, I'm not sure what the rest of the process is from here. I know on previous projects I've run, it's been as simple as two command line commands, or kicking off the CI process again if you've got automated deployment to package managers set up. So assuming it's baked into CI, it could be as simple as merging this PR :)