-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firmware Update integration with the Viewer #4280
Conversation
@@ -152,9 +154,61 @@ Some auxillary functionalities might be affected. Please report this message if | |||
return (int)(floor(scale)); | |||
} | |||
|
|||
const char* file_dialog_open(file_dialog_mode flags, const char* filters, const char* default_path, const char* default_name) | |||
bool directory_exists(const char* dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be set const
include/librealsense2/h/rs_device.h
Outdated
const rs2_raw_data_buffer* rs2_create_flash_backup(const rs2_device* device, rs2_update_progress_callback_ptr callback, void* client_data, rs2_error** error); | ||
|
||
/** | ||
* Enter the device to update state, this will cause the updatable device to disconnect and reconnect as update device. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention that the device must support RS2_EXTENSION_UPDATABLE extension
include/librealsense2/h/rs_device.h
Outdated
@@ -146,6 +146,55 @@ void rs2_connect_tm2_controller(const rs2_device* device, const unsigned char* m | |||
*/ | |||
void rs2_disconnect_tm2_controller(const rs2_device* device, int id, rs2_error** error); | |||
|
|||
/** | |||
* Update device to the provided firmware, the device must be extendable to RS2_EXTENSION_UPDATABLE. | |||
* This call is executed on the caller's thread and it supports progress notifications via the optional callback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this shall be called when the device has already been switched into RS2_EXTENSION_UPDATE_DEVICE
Assumes #4267 as a prerequisite.
Adds streamlined integration of firmware update process directly into the Viewer:
Thanks to #4267 this should be available on all supported platforms and architectures, eliminating limitations of current firmware update tool.
This PR is still being tested so pull on your own risk.