Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pose as extrinsics reference #4507

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Pose as extrinsics reference #4507

merged 2 commits into from
Aug 14, 2019

Conversation

cchen6
Copy link
Contributor

@cchen6 cchen6 commented Jul 25, 2019

Make pose as reference for extrinsics

Copy link
Contributor

@radfordi radfordi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is self consistent in librealsense, but needs testing on the ros side @schmidtp1.

@dorian3d
Copy link
Contributor

Note that this code makes rs-enumerate-devices -c -p recording.bag print NaNs and suspicious numbers.
We know there is an existing bug in rs-enumerate-devices -c -p, but I don't know if the NaNs are caused by it or by side-effects of this PR.

@dorian3d
Copy link
Contributor

I don't see NaNs any longer. The output of this PR looks good to me.

@ev-mp ev-mp changed the base branch from master to development August 1, 2019 06:01
@@ -36,6 +36,9 @@ namespace librealsense
};
bool compress_while_record() const override { return false; }

protected:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see the new function's definition but I actually cannot see where and it is applied in the code.
@cchen6 , can you elaborate?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ev-mp it is used on tm2-device.cpp line 1518. tm2-device as sub device to use it for reference to pose sensor, differ from ds5 device which use first sensor (infrared 1) as reference.

@dorodnic dorodnic merged commit ecc1f8a into IntelRealSense:development Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants