Android UVC backend - Out of memory error fix #4678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- missing pointcloud filter API added. - 3D view added to the camera app.
ev-mp
approved these changes
Aug 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the bulk transfer reads on the streaming endpoints back to USB requests.
The bulk transfer (
ioctl(device, USBDEVFS_BULK, &ctrl)) requires memory allocation of the entire frame size which failed on some devices with "Out of memory" error.Moving back to USB requests (
ioctl(device, USBDEVFS_SUBMITURB, urb)) seems to eliminate this issue.Removing unnecessary synchronization and memcopies from the previous implementation of the backend with USB requests equalized the performance that we had with the bulk transfer implementation.
Fix issues: #3612, #4091, #4215