Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format-security warnings (again) #4721

Merged
merged 2 commits into from
Aug 27, 2019

Conversation

morxa
Copy link
Contributor

@morxa morxa commented Aug 25, 2019

Use string literals in all format strings and cast to char * if necessary. Also include -Wformat, which is necessary if you want to use -Wformat-security.

See also #915 that did something similar.

@dorodnic
Copy link
Contributor

Hi @morxa
Thank you, again, we will try to avoid these in the future

@dorodnic dorodnic merged commit f700d9a into IntelRealSense:development Aug 27, 2019
@morxa
Copy link
Contributor Author

morxa commented Aug 28, 2019

Thanks for merging! With the -Wformat fix, everyone should hopefully notice the problem earlier :)

@morxa morxa deleted the format-security-2 branch August 28, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants