Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wheeled Odometry Calibration Setup Examples #5244

Merged
merged 12 commits into from
Nov 21, 2019

Conversation

krazycoder2k
Copy link
Contributor

Added basic wheeled odometry description / sample drawings/json to T265 documentation.

doc/t265.md Outdated
```
### Extrinsic Calibration for Wheeled Odometry Examples

- All calibration metrics are relative to T265 origin frame. I.e.: They are offsets/rotations *from* the T265 origin *to* the robot's origin. Said another way, we transform a point from frame B (Robot Odometry) to frame A (T265 Pose.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possibly even more clear by adding a formula, A_p = H_AB * B_p, where A_p is the point expressed in frame A, B_p is the point expressed in frame B, and H_AB is the corresponding homogeneous transformation (http://paulfurgale.info/news/2014/6/9/representing-robot-pose-the-good-the-bad-and-the-ugly)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. So just to be clear...H_AB would effectively be the transformation matrix derived from the values in the JSON calibration file. Is that correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schmidtp1
Copy link
Contributor

schmidtp1 commented Nov 14, 2019

Looks good, thanks for the contribution, @krazycoder2k!
One minor note: You could "squash" the commits to help keep the history clean. (e.g. git rebase -i <PARENT-COMMIT> (needs force push)).

@schmidtp1
Copy link
Contributor

schmidtp1 commented Nov 19, 2019

@krazycoder2k, I squashed the commits and created this new PR: #5280.
If you're ok with it, you can close this one (or update based on my new branch).

@krazycoder2k
Copy link
Contributor Author

Thanks @schmidtp1 I'll add the math formula text you suggested to that PR now.

@dorodnic dorodnic changed the base branch from master to development November 21, 2019 08:38
@dorodnic dorodnic merged commit 7fe43a6 into IntelRealSense:development Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants