Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UE4 wrapper 4.24 update and Linux build #5306

Merged
merged 3 commits into from
Dec 5, 2019

Conversation

gaborpapp
Copy link
Contributor

Built the wrapper in Linux with the latest UE 4.24.

@dorodnic
Copy link
Contributor

Hi @gaborpapp
Thank you for the Pull-Request!
Currently CI is rejecting the patch due to the following:
[ERROR] include/librealsense2/hpp/rs_processing.hpp has tabs (this project is using spaces as delimiters)

@gaborpapp
Copy link
Contributor Author

Thanks @dorodnic . Sorry, fixed the tab issue.

@dorodnic
Copy link
Contributor

I'm somewhat of UE newbie, do you have some documentation on setting-up UE on Linux?
I want to give it all a try before merging

@gaborpapp
Copy link
Contributor Author

I'm not very experienced either, but it's not difficult to set up. This can help:
https://docs.unrealengine.com/en-US/Platforms/Linux/BeginnerLinuxDeveloper/SettingUpAnUnrealWorkflow/index.html
I built it with the latest 4.24-preview-3 branch, but I hope it works with the release branch as well.

@dorodnic
Copy link
Contributor

dorodnic commented Dec 1, 2019

Thanks (Still working on it, in-between other things)

@dorodnic
Copy link
Contributor

dorodnic commented Dec 2, 2019

It works! 🎉 🎉
After many hours of fiddling around with Linux Vulkan drivers I can confirm everything is working on Ubuntu 16 and Windows with UE 4.24
Again, thank you so much for taking the time to port the wrapper to Linux!
I had two small questions - @gaborpapp

  1. Given 4.24 is not officially out yet, does this PR depends on 4.24 or can it work with say 4.23?
  2. To fix final linker errors on Linux, I had to do something to the extent of:
    sudo make DESTDIR="/.../UnrealEngine-4.24/Engine/Extras/ThirdPartyNotUE/SDKs/HostLinux/Linux_x64/v15_clang-8.0.1-centos7/x86_64-unknown-linux-gnu" install from librealsense build folder. Is this the correct method for passing dependencies into engine build? (I couldn't find anything on it from google) I'll try to update readme.mp accordingly with my steps, but I'd like to learn what is the proper way of doing this. Any info would be appreciated.

@gaborpapp
Copy link
Contributor Author

Great!

  1. I will try it with 4.23, I rebuild the editor and get back to you.
  2. I don't remember any linker errors. UE4 just could not find the librealsense library when the project was loaded, but setting LD_LIBRARY_PATH solved it.

@gaborpapp
Copy link
Contributor Author

I made changes for UE 4.23 tested with the latest release 4.23.1. Now this should compile with 4.23 and 4.24 as well.

On my Fedora 30 UnrealEditor cannot load the plugin without running export LD_LIBRARY_PATH=/usr/local/lib64 first. This could be solved by statically linking librealsense to the wrapper plugin if necessary.

@dorodnic dorodnic merged commit 38c4fda into IntelRealSense:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants