Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Software Device update #5333

Merged
merged 23 commits into from
Mar 6, 2020
Merged

Software Device update #5333

merged 23 commits into from
Mar 6, 2020

Conversation

lramati
Copy link
Contributor

@lramati lramati commented Nov 27, 2019

SW Device infrastructure enhance
Fix python wrapper FW update callback
Tracked on: DSO-14348

@dorodnic
Copy link
Contributor

dorodnic commented Dec 5, 2019

Continuing and based on #4269

@lramati
Copy link
Contributor Author

lramati commented Dec 12, 2019

Merged in @callendorph's code.
The PR is now complete in terms of features, but I still need to add python bindings and write examples before it can be merged

Lior Ramati and others added 15 commits January 15, 2020 18:20
The API methods for rs2_software_sensor_add_*_stream can return an
error in various cases. In the old implementation, the returned error code
was not checked before sending the result to the `stream_profile` constructor.
This was causing the originating error to get swallowed and made debugging
the actual problem harder. This fixes this method so that the
first error is reported and not subsequent errors.
This adds a new private method for software_sensor for searching
for profiles by UID. This also makes this code more readable.
Issue IntelRealSense#4197

This adds the ability for the user with access to the `software_device` and
`software_sensor` classes to configure and set the `camera_info` parameters.
This allows for serial number, name, etc. to be written and configured.
UInlike @callendorph's implementation, it must be specified when you first register the stream_profile
@lramati
Copy link
Contributor Author

lramati commented Jan 15, 2020

Force pushed to rebase on development.
Example is still missing, but this is now mergeable

@lramati lramati marked this pull request as ready for review January 15, 2020 17:15
@dorodnic
Copy link
Contributor

dorodnic commented Mar 5, 2020

Ping @ev-mp

include/librealsense2/h/rs_sensor.h Outdated Show resolved Hide resolved
src/rs.cpp Outdated Show resolved Hide resolved
src/rs.cpp Show resolved Hide resolved
include/librealsense2/h/rs_internal.h Show resolved Hide resolved
include/librealsense2/hpp/rs_internal.hpp Outdated Show resolved Hide resolved
src/option.h Show resolved Hide resolved
src/realsense.def Show resolved Hide resolved
src/rs.cpp Show resolved Hide resolved
src/rs.cpp Show resolved Hide resolved
src/rs.cpp Show resolved Hide resolved
src/software-device.cpp Outdated Show resolved Hide resolved
src/types.h Outdated Show resolved Hide resolved
src/types.h Outdated Show resolved Hide resolved
src/types.h Outdated Show resolved Hide resolved
wrappers/python/python.hpp Outdated Show resolved Hide resolved
src/rs.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last small fix

Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ev-mp ev-mp merged commit 213596b into IntelRealSense:development Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants