-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Software Device update #5333
Software Device update #5333
Conversation
Continuing and based on #4269 |
Merged in @callendorph's code. |
…ensor notifications
The API methods for rs2_software_sensor_add_*_stream can return an error in various cases. In the old implementation, the returned error code was not checked before sending the result to the `stream_profile` constructor. This was causing the originating error to get swallowed and made debugging the actual problem harder. This fixes this method so that the first error is reported and not subsequent errors.
This adds a new private method for software_sensor for searching for profiles by UID. This also makes this code more readable.
Issue IntelRealSense#4197 This adds the ability for the user with access to the `software_device` and `software_sensor` classes to configure and set the `camera_info` parameters. This allows for serial number, name, etc. to be written and configured.
UInlike @callendorph's implementation, it must be specified when you first register the stream_profile
Force pushed to rebase on development. |
Ping @ev-mp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last small fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
SW Device infrastructure enhance
Fix python wrapper FW update callback
Tracked on: DSO-14348