Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to enable laser always on and fixed a minor performanc… #5462

Conversation

daversintel
Copy link
Contributor

…e prolem in rendering

@dorodnic
Copy link
Contributor

Hi @daversintel
Thanks for the PR
Could you please take a look at #4666 for all the different locations new options have to be reflected and add the new option accordingly? While not all options are necessarily required immediately in all wrappers, not adding new options right away causes mistakes down the line (someone else may adds new option to the wrapper at a place where your option would be)
Otherwise, looks good to me 👍

@dorodnic
Copy link
Contributor

Perhaps option description can be expanded as well?
"Enable Laser On constantly (GS SKU Only)" is not very clear.
I'd suggest something like - Keep laser active in-between frames as opposed to just during frame exposure, thus improving multi-camera performance consistency (relevant for global shutter devices only - D430, D435 and D435i)

@daversintel
Copy link
Contributor Author

The option description is updated as suggested except the device models since it will also apply to new coming devices.

@daversintel
Copy link
Contributor Author

It looks like not all the options are in all the wrappers. Not sure which wrapper should have this in. Can your team handle the wrapper part?

@dorodnic
Copy link
Contributor

@daversintel - for this PR to be merged, new option must be added to wrappers.
You can use #4666 as reference for which files need to be changed.

Copy link
Contributor

@radfordi radfordi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to all the wrappers as well. See #5208 for an example.

@daversintel daversintel closed this Mar 9, 2020
@daversintel daversintel deleted the enable_laser_always_on branch April 9, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants