-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sensor extensions #5468
Add sensor extensions #5468
Conversation
sr300_color_sensor and l500_color_sensor inherit from color_sensor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls verify C#, Matlab and NodeJS bindings
std::string("0B3A"), | ||
std::string("0B3D") })) | ||
{ | ||
WARN("Skipping test - no motion sensor is device type: " << PID.first << (PID.second ? " USB3" : " USB2")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no motioncolor sensor
@@ -3823,6 +3823,108 @@ TEST_CASE("Per-frame metadata sanity check", "[live][!mayfail]") { | |||
} | |||
} | |||
|
|||
TEST_CASE("color sensor API", "[live][options]") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to rearrange the test so that there will be a concentrated map of all the sensors extensions per PID for clearness and maintenance instead of having separate tests per sensor type.
TEST_CASE("color sensor API", "[live][options]") | ||
{ | ||
rs2::context ctx; | ||
if (make_context(SECTION_FROM_TEST_NAME, &ctx, "2.17.1")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.17.12.31.0
REQUIRE(profile); | ||
REQUIRE_NOTHROW(dev = profile.get_device()); | ||
REQUIRE(dev); | ||
dev_type PID = get_PID(dev); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using pipe can be avoided here as you'd probably iterate over ctx.query_devices()
list
Add color_sensor, motion_sensor and fisheye_sensor extensions.
Enable the option to dev.firstrs2::color_sensor() or sensor.isrs2::color_sensor() etc.