Make firmware URL overrideable #6098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radfordi
approved these changes
Mar 20, 2020
radfordi
reviewed
Mar 20, 2020
common/fw/CMakeLists.txt
Outdated
| @@ -8,30 +8,32 @@ file(READ "firmware-version.h" ver) | |||
|
|
|||
| message(STATUS "Fetching recommended firmwares:") | |||
|
|
|||
| set(REALSENSE_FIRMWARE_URL "http://realsense-hw-public.s3.amazonaws.com" CACHE STRING) | |||
There was a problem hiding this comment.
I thought the docstring was (annoyingly) required here. Any idea why this works?
set(<variable> <value>... CACHE <type> <docstring> [FORCE])There was a problem hiding this comment.
Indeed, it does seem to be failing the CI here. Fixed now.
|
Thanks @mikepurvis @radfordi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change as proposed in #5114. This permits the firmware binaries to be mirrored on-site for more restrictive CI environments that do not permit external network access at build time.
Closes: #5114