L500 device - block return to visual preset default option + cancel max_range on stream start #6617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Jun 17, 2020
maloel
reviewed
Jun 17, 2020
src/l500/l500-options.cpp
Outdated
| @@ -164,6 +165,12 @@ namespace librealsense | |||
| case RS2_L500_VISUAL_PRESET_CUSTOM: | |||
| move_to_custom(); | |||
| break; | |||
| case RS2_L500_VISUAL_PRESET_DEFAULT: | |||
| LOG_ERROR("changing back to default is disabled by design"); | |||
There was a problem hiding this comment.
Need to give context: in the log, someone will not understand what you're talking about
maloel
reviewed
Jun 17, 2020
src/l500/l500-options.cpp
Outdated
| @@ -164,6 +165,12 @@ namespace librealsense | |||
| case RS2_L500_VISUAL_PRESET_CUSTOM: | |||
| move_to_custom(); | |||
| break; | |||
| case RS2_L500_VISUAL_PRESET_DEFAULT: | |||
| LOG_ERROR("changing back to default is disabled by design"); | |||
| throw invalid_value_exception(to_string() << "the Default preset signifies that the controls have not been changed \n" | |||
maloel
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System requirement - When the user try to return to visual preset "Default" he will get an error on the viewer + exception on the API
Tracked on: RS5-7898