-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added patch scripts for debian 10 and linux vanilla #6653
Conversation
dmesg output
|
patch -p1 < ../patch-${KV1}.${KV2}.${KV3}-rt${RT}.patch | ||
|
||
# this will apply all patches | ||
patch -p1 < ../*.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewhodel , you need to specify and provide the exact patches to be built into the kernel.
Though I don't see how this is going be implemented - Librealsense patches are different from kernel to kernel so you can't have a single version/ fit all approach.
This attempts on any kernel version you specify using all of the patches in your repo.
The only kernel you have specified in the patches is 4.8, this works with 5.0.21 as specified in the comments.
Thank You,
Andrew Hodel
… On Jun 22, 2020, at 4:47 AM, ev-mp ***@***.***> wrote:
@ev-mp commented on this pull request.
In scripts/patch-debian-10.sh:
> +# use -c to continue existing downloads
+wget -c https://mirrors.edge.kernel.org/pub/linux/kernel/v5.x/linux-${KV1}.${KV2}.${KV3}.tar.xz
+wget -c https://mirrors.edge.kernel.org/pub/linux/kernel/projects/rt/${KV1}.${KV2}/patch-${KV1}.${KV2}.${KV3}-rt${RT}.patch.xz
+
+# use -k, keep the input files so they don't have to be redownloaded if you restart the script
+# use -f, overwrite existing in the case of restart
+unxz -kf linux-${KV1}.${KV2}.${KV3}.tar.xz
+unxz -kf patch-${KV1}.${KV2}.${KV3}-rt${RT}.patch.xz
+
+tar xf linux-${KV1}.${KV2}.${KV3}.tar
+cd linux-${KV1}.${KV2}.${KV3}
+
+patch -p1 < ../patch-${KV1}.${KV2}.${KV3}-rt${RT}.patch
+
+# this will apply all patches
+patch -p1 < ../*.patch
@andrewhodel , you need to specify and provide the exact patches to be built into the kernel.
Though I don't see how this is going be implemented - Librealsense patches are different from kernel to kernel so you can't have a single version/ fit all approach.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@andrewhodel hello, as I've explained in #6650 this approach is not viable.
The patches are managed and specified per specific kernel version. There is no solution that fits all kernel.
Please review #6650 again, as this in its current form this PR cannot lead to merge. |
You can just apply all patches using a wildcard and the ones for the
correct kernel code will apply properly.
It's a fundamental of patch and diff routines.
Andrew
…On Tue, Jun 23, 2020 at 12:58 AM ev-mp ***@***.***> wrote:
@andrewhodel <https://github.com/andrewhodel> hello, as I've explained in
#6650 <#6650> this
approach is not viable.
This attempts on any kernel version you specify using all of the patches
in your repo.
The patches are managed and specified per specific kernel version. There
is no solution that fits all kernel.
The only kernel you have specified in the patches is 4.8, this works with
5.0.21 as specified in the comments.
1. It is not clear which patch you reviewed to reach this conclusion.
The official patches cover all Ubuntu LTS kernels in the range of 4.4 ....
5.3 (Xenial+Bionic).
In case you're not sure about which patches should be selected you can
invoke/review the script from the [installation guide]:(
https://github.com/IntelRealSense/librealsense/blob/master/doc/installation.md#prerequisites
)
./scripts/patch-realsense-ubuntu-lts.sh
2. The script doesn't evaluate the selected patches, so how can one
verify that (a) proper patches are selected and (b) the patches were
applied correctly ?
What librealsense-specific tests do you run to validate that the
compiled kernel was patched properly ?
Please review #6650
<#6650> again, as
this in its current form this PR cannot lead to merge.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6653 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVCSOWYSTCNBUFXXCBW2DRYBHCNANCNFSM4ODBNKRA>
.
|
That's why a diff is byte by byte, by design only the patch files that can
be applied will be applied and if you are only creating files for each
kernel version then you will get the right one with patch -p1 < *.patch or
you created 2 patch files that are identical for different versions which
will still work in this case.
…On Tue, Jun 23, 2020 at 9:24 AM Andrew Hodel ***@***.***> wrote:
You can just apply all patches using a wildcard and the ones for the
correct kernel code will apply properly.
It's a fundamental of patch and diff routines.
Andrew
On Tue, Jun 23, 2020 at 12:58 AM ev-mp ***@***.***> wrote:
> @andrewhodel <https://github.com/andrewhodel> hello, as I've explained
> in #6650 <#6650>
> this approach is not viable.
>
> This attempts on any kernel version you specify using all of the patches
> in your repo.
>
> The patches are managed and specified per specific kernel version. There
> is no solution that fits all kernel.
>
> The only kernel you have specified in the patches is 4.8, this works with
> 5.0.21 as specified in the comments.
>
>
> 1. It is not clear which patch you reviewed to reach this conclusion.
> The official patches cover all Ubuntu LTS kernels in the range of 4.4 ....
> 5.3 (Xenial+Bionic).
> In case you're not sure about which patches should be selected you
> can invoke/review the script from the [installation guide]:(
> https://github.com/IntelRealSense/librealsense/blob/master/doc/installation.md#prerequisites
> )
> ./scripts/patch-realsense-ubuntu-lts.sh
> 2. The script doesn't evaluate the selected patches, so how can one
> verify that (a) proper patches are selected and (b) the patches were
> applied correctly ?
> What librealsense-specific tests do you run to validate that the
> compiled kernel was patched properly ?
>
> Please review #6650
> <#6650> again, as
> this in its current form this PR cannot lead to merge.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#6653 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAFVCSOWYSTCNBUFXXCBW2DRYBHCNANCNFSM4ODBNKRA>
> .
>
|
@andrewhodel hello,
|
Patches, and the patch code originally developed for old unix systems and
still in use 40+ years later will only apply a patch file if the code
blocks being modified are 100% the same.
Your concern about rebuilding the kernel is just when speaking about 1
distribution, Ubuntu and DKMS specifically. It is not true with the other
hundreds of distributions.
Andrew
…On Tue, Jul 21, 2020 at 2:10 PM ev-mp ***@***.***> wrote:
@andrewhodel <https://github.com/andrewhodel> hello,
In order to proceed with the PR we'll need your cooperation to address the
comments.
1. This question was already raised but I need to reiterate it - what
method did you use to ensure that the patches were properly applied?
As already stated Realsense Depth cameras are UVC-compliant devices
that run with vanilla kernels. Hence the lsusb's cannot be used to
assert that the correctness of the patches. See #6837
<#6837> for
alternative methods.
2. Recompiling the whole kernel is not a method we recommend, and the
script need to be refactored such that instead of recompiling and replacing
the kernel only the affected loadable modules will be rebuilt as in
Ubuntu's case.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6653 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFVCSMMBFSKZZGO762H3ATR4XY3FANCNFSM4ODBNKRA>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewhodel , thank you for the contribution.
L515 working on Debian 10