-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update patch-arch.sh based on #4271 #6709
Conversation
@puzzlepaint , thank you for the PR!
|
Thanks for the response, it is good to know that the metadata part was still missing. I assume this can be fixed by applying one of the
It indicates one missing format: Running
I am not at all familiar with the Linux kernel or the UVC driver, but it seems to me that the GUID from the camera formats patch that corresponds to the RW16 format does not match the value + #define UVC_GUID_FORMAT_BAYER16 \
+ { 'R', 'W', '1', '6', 0x66, 0x1a, 0x42, 0xa2, \
+ 0x90, 0x65, 0xd0, 0x18, 0x14, 0xa8, 0xef, 0x8a} Probably that should be added as well. But that might be related to the patch files then, and not to the patching script. |
Thanks for the verification inputs, |
@puzzlepaint , try to click on the "Info" icon above each viewpoint as highlighted to check the metadata presence |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's ready for merge - the metadata patch is applied correctly.
Installing librealsense on Manjaro Linux, I ran into the exact issues described in #4271 from a year ago. This PR proposes to update
patch-arch.sh
accordingly. Notice that it does not update the actual patch file. This may still need adaptation depending on the kernel version that is used (which however seemed to be rather trivial in my case for kernel 5.6.16).