controls emitter options list changed to dynamic #6793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev-mp
reviewed
Jul 12, 2020
| int indexOfCurrentEmitter = 0; | ||
| int indexOfCurrentHwPreset = 0; | ||
|
|
||
| RsContext ctx = new RsContext(); |
There was a problem hiding this comment.
There is over-use of query_devices() API which affects performance.
Why the current device is not stored in the Model class and then dispatched to the View/View-Model?
| <resources> | ||
|
|
||
| <string-array name="controls_emitter_entries"> | ||
| <item>"OFF"</item> |
There was a problem hiding this comment.
This can be done dynamically with get_option_value_description API.
| <item>"LED"</item> | ||
| </string-array> | ||
|
|
||
| <string-array name="controls_hw_presets_entries"> |
added 2 commits
July 12, 2020 11:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggered by jira ticket: DSO-15273
In android camera application, the relevant values for the emitter options are now dynamic.
This implements also the requirements due to jira ticket: RS5-8168