Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add L515 humidity temperature option #7490

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

Nir-Az
Copy link
Collaborator

@Nir-Az Nir-Az commented Oct 4, 2020

Tracked on [RS5-9069]

GUI illustration :
image

@Nir-Az Nir-Az requested a review from ev-mp October 4, 2020 09:06
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls fix the missing enumerations

include/librealsense2/h/rs_option.h Outdated Show resolved Hide resolved
src/l500/l500-depth.cpp Outdated Show resolved Hide resolved
wrappers/matlab/option.m Outdated Show resolved Hide resolved
wrappers/nodejs/index.js Outdated Show resolved Hide resolved
wrappers/nodejs/index.js Outdated Show resolved Hide resolved
wrappers/nodejs/src/addon.cpp Outdated Show resolved Hide resolved
@Nir-Az Nir-Az requested a review from ev-mp October 4, 2020 12:32
include/librealsense2/h/rs_option.h Show resolved Hide resolved
RS2_OPTION_SEQUENCE_SIZE, /**< HDR Sequence size */
RS2_OPTION_SEQUENCE_ID, /**< HDR Sequence ID - 0 is not HDR; sequence ID for HDR configuartion starts from 1 */
RS2_OPTION_HUMIDITY_TEMPERATURE, /**< Humidity temperature*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls specify units

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

wrappers/python/pybackend.cpp Show resolved Hide resolved
@Nir-Az Nir-Az requested a review from ev-mp October 5, 2020 10:34
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ev-mp ev-mp merged commit 1ef7b3a into IntelRealSense:development Oct 5, 2020
@Nir-Az Nir-Az deleted the add_hum_sensor_to_viewer branch April 8, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants