Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Resource deadlock avoided exception on thread join #7687

Merged
merged 1 commit into from
Nov 3, 2020
Merged

Fix Resource deadlock avoided exception on thread join #7687

merged 1 commit into from
Nov 3, 2020

Conversation

Domos
Copy link
Contributor

@Domos Domos commented Nov 1, 2020

It's illegal to call _thread->join(); in capture_loop().
Setting _is_capturing = false breaks to outer while loop, and the thread should be terminated.

ev-mp
ev-mp approved these changes Nov 3, 2020
View reviewed changes
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Domos , thank you for the contribution!
The change makes sense, even though that branch of select apparently haven't been utilized frequently..
Much appreciated.

@ev-mp ev-mp merged commit 3ca4554 into IntelRealSense:development Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ev-mp ev-mp ev-mp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Domos @ev-mp