Wrap Viewer/DQT error pop up text #7781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 17, 2020
maloel
reviewed
Nov 25, 2020
maloel
reviewed
Nov 25, 2020
maloel
reviewed
Dec 3, 2020
maloel
reviewed
Dec 3, 2020
maloel
reviewed
Dec 3, 2020
maloel
reviewed
Dec 6, 2020
common/utilities/string/wrap.cpp
Outdated
| if( non_space_index != std::string::npos ) | ||
| { | ||
| // Remove trailing spaces | ||
| remaining_paragraph = remaining_paragraph.substr( non_space_index ); |
There was a problem hiding this comment.
This removes the leading spaces, not the trailing...
maloel
reviewed
Dec 14, 2020
maloel
reviewed
Dec 14, 2020
Nir-Az
force-pushed
the
wrap_error_messages_by_pixels
branch
from
12c92bb
to
f407ddb
Compare
maloel
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error pop up text on Viewer and DQT application is not wrapped,
It use a ImGui::InputTextMultiline because the input text is dynamic
(For static text we can use ImGui API - "ImGui::PushTextWrapPos / ImGui::PopTextWrapPos ")
Example before fix:
Example after fix:
Tracked on [RS5-9465]