Remove confidence stream from android settings #8261
Conversation
|
|
||
| // Entering Settings when all stream on (including confidence) result in an application crash. | ||
| // as a workaround we remove confidence profile as it is not supported on display anyway. | ||
| // See [RS5-8989] |
There was a problem hiding this comment.
remove jira ticket reference from comment in code
|
|
||
| private void RemoveUnsupportedProfiles(List<StreamProfileSelector> streamProfiles){ | ||
|
|
||
| // Entering Settings when all stream on (including confidence) result in an application crash. |
There was a problem hiding this comment.
The problem is not when entering the Settings Activity, when when we leave it and go back to Preview Activity.
I would have changed the comment as:
// Confidence steam format is RAW8, and it is not supported for display.
// Its removal is necessary until format RAW8 display is enabled.
Feel free to use this or rephrase it by yourself.
There was a problem hiding this comment.
I'd move this comment to right before line 356, too
There was a problem hiding this comment.
I did it,
but when someone will read this comment 1 year from now and say hey, I can add support for raw8 and remove this patch, he will not know about the problem, he don't have a ticket to read, and no information on the comment.
And he will 99% won't test the flow that caused the issue.
Don't you guys think it's necessary?
There was a problem hiding this comment.
I think the ticket number is harmless -- but you're referring to the other comment, right?
Tracked on [RS5-8989]