Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository server #8414

Merged
merged 2 commits into from
Feb 23, 2021
Merged

Conversation

doronhi
Copy link
Contributor

@doronhi doronhi commented Feb 22, 2021

replaced realsense-hw-public.s3.amazonaws.com and realsense-hw-publics3-eu-west-1.amazonaws.com addresses with librealsense.intel.com

Installation tested on Ubuntu 16.04, 18.04, 20.04
Tracked on: DSO-16482

….s3-eu-west-1.amazonaws.com addresses with librealsense.intel.com
@@ -81,7 +81,7 @@ inline ImVec4 blend(const ImVec4& c, float a)

namespace rs2
{
constexpr const char* server_versions_db_url = "http://realsense-hw-public.s3-eu-west-1.amazonaws.com/Releases/rs_versions_db.json";
constexpr const char* server_versions_db_url = "http://librealsense.intel.com/Releases/rs_versions_db.json";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change - part of a separate UC

@@ -1,7 +1,7 @@
# License: Apache 2.0. See LICENSE file in root directory.
# Copyright(c) 2019 Intel Corporation. All Rights Reserved.
message(STATUS "Checking internet connection...")
file(DOWNLOAD "http://realsense-hw-public.s3-eu-west-1.amazonaws.com/Releases/connectivity_check" "${CMAKE_CURRENT_SOURCE_DIR}/connectivity_check" SHOW_PROGRESS TIMEOUT 5 STATUS status)
file(DOWNLOAD "http://librealsense.intel.com/Releases/connectivity_check" "${CMAKE_CURRENT_SOURCE_DIR}/connectivity_check" SHOW_PROGRESS TIMEOUT 5 STATUS status)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https, in this line and in all changes hereafter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed. Tested on all machines again.

revert changes where the link is a part of a separate UC
@doronhi doronhi requested a review from ev-mp February 23, 2021 05:15
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ev-mp ev-mp merged commit f294fba into IntelRealSense:development Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants